Refine select inline criteria to keep arranged computed columns
#1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Feb 14, 2024
|
Thanks for taking a stab at this! |
|
@mgirlich could you please take a look at this PR too? |
mgirlich
reviewed
Feb 28, 2024
mgirlich
approved these changes
Feb 28, 2024
ejneer
force-pushed
the
select_inlining_arrange
branch
from
cf4781d
to
e3dc35e
Compare
hadley
reviewed
Mar 4, 2024
| is_bijective_projection <- function(vars, names_prev) { | ||
| vars <- unname(vars) | ||
| identical(sort(vars), names_prev) | ||
| select_can_be_inlined <- function(lazy_query, vars) { |
There was a problem hiding this comment.
I made a few tweaks here to hopefully make the logic a bit clearer.
hadley
reviewed
Mar 4, 2024
| lf <- lazy_frame(x = 1) | ||
|
|
||
| # shouldn't inline | ||
| out <- lf %>% mutate(z = 2) %>% arrange(x, z) %>% select(x) |
There was a problem hiding this comment.
I'm not sure this is testing the right thing because when I run it, I see:
SELECT `x`
FROM (
SELECT `df`.*, 2.0 AS `z`
FROM `df`
) AS `q01`
Warning message:
ORDER BY is ignored in subqueries without LIMIT
ℹ Do you need to move arrange() later in the pipeline or use window_order() instead?
There was a problem hiding this comment.
Or maybe that is the expected behaviour? But definitely worth a snapshot test, I think.
There was a problem hiding this comment.
Yeah that is expected. I've re-added the snapshot I removed in my prior commit.
|
Thanks for your work on this @ejneer — it's much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1437
This will stop
arranged computed columns from being inlined away from subqueries. Of course the subqueryORDER BYwarning will be thrown, but I think that is expected behavior.Before:
Created on 2024-02-07 with reprex v2.0.2
After:
Created on 2024-02-07 with reprex v2.0.2